Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipping tracks on any NonStreamableError when getting downloadable info (#645) #707

Merged
merged 2 commits into from
Jul 7, 2024

Conversation

mortalis13
Copy link
Contributor

Skipping tracks on any NonStreamableError when getting downloadable info (#645)
Based on the linked issue, also added check for fallback_id as it was empty and didn't result in a correct final error.

I added the generic NonStreamableError catch as I think a track should be skipped on any reason for that exception, letting other possibly healthy tracks to be processed.

The WrongGeolocation Deezer exception from the linked album in the link affects only 2 tracks, so those cannot be downloaded. But others can.

…nfo (nathom#645)

Based on the linked issue, also added check for fallback_id as it was empty and didn't result in a correct final error
@pio2398
Copy link

pio2398 commented Jun 25, 2024

I confirm that the problem I reported has been resolved.

@nathom
Copy link
Owner

nathom commented Jul 7, 2024

Looks good. Thank you!

@nathom nathom merged commit 006605c into nathom:dev Jul 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants