Core - StorageFile #146
Core - StorageFile #146
Conversation
|
Hey thanks for the contribution! I will have a look once I'm done with touch and the RetroArch stuff I'm currently busy wtith. |
|
Okay, sounds good! |
|
I didn't do a compilation test until now, and there were some compiler errors. So I went ahead and fixed them up. |
|
The class in its simplest, probably functional form is finished. I'm open for a review now. |
|
There are a lot of issues with the class (i.e. the writing and reading functions not working correctly) so I'm going to try and fix them. |
|
So I have a new idea. Instead of using my approach from yesterday, I can use a new one that should bring this implementation of this idea closer to the original idea. There will be a new class called StorageObject, which contains variables for the value, name, and type (like int or string for example). In StorageFile, there will be a whole std::vector containing these StorageObjects. This means readFromFile can read from the std::vector, not directly from the XML file. writeToFile should be the same, and there will be a new function to parse the XML file into StorageObject objects. I was also thinking of implementing the save function with individual elements, but that might require more work. |
|
I'm pretty sure what I wrote in the issue can be implemented exactly as I wrote it, it's a design more than an "idea" |
|
Yeah, I think I can do it if I put more effort. Right now, you don't have to write a lot of code, but you might still have to write code. |
|
I just confirmed, and now everything works as intended! I had to fix up some runtime errors mostly relating to how I was treating pointers. (I was treating them more like a normal variable than a pointer, there were many Segmentation Faults) |
|
Wow, I messed up. Tried to get the latest changes from the upstream main branch. |
|
Actually wait, I didn't, but it's a big mess |
|
What did you do 👀 |
|
I did a I wanted to update my fork since there was a new commit. |
|
Yes, I literally don't know how to properly use git. I use GitHub Desktop most of the time |
|
Rebase is the right choice when making a PR |
|
Yeah, but I'm not sure why it recommitted everything that I already committed to this Pull Request |
|
Because when you rebase it removes all your commits, updates the branch and re-applies your commits back on the updated branch. As a consequence, your commits are not the same as the previous ones (same content but new hash). The history has also been rewritten, making a force push mandatory. So since the commits are all same same, but different, but still same, GitHub treats them all as new commits in the PR. |
|
Actually, yes, I should've done a force push. I pushed directly through GitHub Desktop, so it must've not done a force push. I was thinking of reverting to the previous commit before I rebased, and try again. |
See natinusala#140 in the upstream repo for more information.
It checks in the brls.json file for a key called "appname" and sets the config folder to, for example, /config/borealis_demo
If the client is on Switch, then config_folder is set to /config/borealis_demo. If it's on PC, then config_folder is set to ./config/borealis_demo. (Where . is the folder where the executable is)
Tested via the GLFW Platform. Finally was able to compile and run Borealis on macOS.
Macros - Added and changed up the macros BasicStorageFile - Switched from using vectors to maps BasicStorageFile - Slightly changed some of the logic in writeToFile BasicStorageFile - Removed the createStorageObject functions
Demo - Changed Font Size for the text
Util - Fixed the conversion functions borealis.hpp - Added Util.hpp
Now I love VSCode more. BasicStorageFile - Added statement to clear up an already used allStorageObjects map (might've caused a segmentation fault)
|
Well, it happened again. :( |
|
Well actually, I fixed it! But it counted all the commits from today. And it didn't update from the upstream |
Util.cpp - Removed copyright
BasicStorageFile - Fixed bug where the app would crash when the config folder doesn't exist BasicStorageFile - Fixed bug where the saving document part never got it's error code SettingsFile - Changed from class to struct
BasicStorageFile - Changed error handling logic with saving Macros - Changed the name of some parameters to make it less confusing
|
Alright, I have finally tested on the Nintendo Switch! It seems to work fine, just the weird segmentation faults sometimes. |
The Switch build complained about std::filesystem::current_path().
|
So because your issue was a "design", not an "idea", I decided to rewrite the entire PR to match the design a lot more. It has some missing functions from the original design, but otherwise, it works fine. |
|
Reopened in #175 due to branch reorganization. |
Check #140 for context clues
This is my implementation of the StorageFile class idea, for the release of Borealis. This is a work-in-progress Pull Request since I just started on this.
To-Do with this Pull Request:
What's finished: