Cherry picks for v2.10.21 RC1 #5898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should pull in updates to dependencies as well. I can look at complete list of PRs since 2.10.20 later on.. |
In `processClusterCreateStream` there was a call to `reflect.DeepEqual` with different types making it always fail.
`mset.config()` is the config itself, whereas `sa.Config` is a pointer to the config. So we need to pass `mset.config()` as a pointer instead.
In `processClusterCreateConsumer` this was done as well:
```go
cfg := o.config()
if isConfigUpdate = !reflect.DeepEqual(&cfg, ca.Config); isConfigUpdate {
```
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Waldemar Quevedo <wally@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
changed to update the account issuer for an account to always update otherwise the information shown in accountz will not be consistent with the decoded JWT
…g snapshot restore or restart. We had a condition where an old index.db was not able to properly restore a stream due to max msgs per subject being set and certain blocks being compacted away and removing subject info for those sequences. In addition we fixed recovery after Truncate and PurgeEx by subject when the index.db was corrupt or not available. This change also moves generating the index.db file to after writing the blocks during a snapshot and we do a force call to make sure it is written even when complex. Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
wallyqs
force-pushed
the
downstream/v2.10.21
branch
from
c8c0274
to
a13b600
Compare
|
Added the dependencies updates, some test fixes and this fix for stream create (#5854) |
|
Any others we should pull in from your perspective? |
|
There are some other PRs with testing updates that we could also include:
Also need to bump the Go version to 1.22.7 for the release. |
|
Up to you on test updates, not customer impacting but might make release easier to get through the builds. +1 on bumping Go version. Any Alpine updates we need to consider? |
Bumps [coverallsapp/github-action](https://github.com/coverallsapp/github-action) from 2.2.3 to 2.3.0. - [Release notes](https://github.com/coverallsapp/github-action/releases) - [Commits](coverallsapp/github-action@3dfc556...643bc37) --- updated-dependencies: - dependency-name: coverallsapp/github-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…5781) 1. Add test for consuming a stream with a given sequence start offset. - Durable consumer - Durable consumer with `Bind` - Pull consumer - Synchronous consumer - Callback subscription - Channel subscription - Get stream message - Get last stream message by subject 2. Add test where a durable consumer ACKs messages that have been deleted from a stream Signed-off-by: Marco Primi <marco@nats.io>
Wait for stream leader after scale up should avoid some reliability isses. Also tweak helpers for better logging. Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Waldemar Quevedo <wally@nats.io>
|
This one is ready, we are ok on alpine changes too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes:
reflect.DeepEqualboth receiving pointers on stream create #5854TestJetStreamClusterStreamMaxAgeScaleUp#5887