-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIXED] Rebuild state if matched properly for index.db but we find additional blocks #5907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… last block by index.db, we still need to check for additional blocks. Signed-off-by: Derek Collison <derek@nats.io>
MauriceVanVeen
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
neilalexander
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Derek Collison <derek@nats.io>
neilalexander
pushed a commit
that referenced
this pull request
Sep 20, 2024
…ditional blocks (#5907) When determining to rebuild state, when we match the last record in the last block indicated by index.db, we still need to check for additional blocks. Signed-off-by: Derek Collison <derek@nats.io> --------- Signed-off-by: Derek Collison <derek@nats.io>
neilalexander
pushed a commit
that referenced
this pull request
Sep 20, 2024
…ditional blocks (#5907) When determining to rebuild state, when we match the last record in the last block indicated by index.db, we still need to check for additional blocks. Signed-off-by: Derek Collison <derek@nats.io> --------- Signed-off-by: Derek Collison <derek@nats.io>
neilalexander
pushed a commit
that referenced
this pull request
Sep 20, 2024
…ditional blocks (#5907) When determining to rebuild state, when we match the last record in the last block indicated by index.db, we still need to check for additional blocks. Signed-off-by: Derek Collison <derek@nats.io> --------- Signed-off-by: Derek Collison <derek@nats.io>
neilalexander
added a commit
that referenced
this pull request
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When determining to rebuild state, when we match the last record in the last block indicated by index.db, we still need to check for additional blocks.
Signed-off-by: Derek Collison derek@nats.io