New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KV GetEntryAsync using TryFromBase64String buffer incorrectly #385

Closed

mtmk opened this issue Feb 9, 2024 · 0 comments · Fixed by #387

Labels

bug

Collaborator

mtmk commented Feb 9, 2024

We should allocate an oversized buffer based on string input length in NatsKVStore.GetEntryAsync() method (see also link below).

Looks like ReaderBufferSize is used in NatsKVStore.cs - will decreasing it have an effect? Or is its usage there incorrect?

Originally posted by @caleblloyd in #383 (comment)

mtmk added the bug label

mtmk mentioned this issue

Buffer defaults avoiding LOH #383

Merged

mtmk linked a pull request

that will close this issue

Fixed base64 decode buffer size #387

Merged

mtmk closed this as completed in #387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment