Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed base64 decode buffer size #387

Merged
merged 1 commit into from
Feb 10, 2024
Merged

Conversation

mtmk
Copy link
Collaborator

@mtmk mtmk commented Feb 9, 2024

Convert.TryFromBase64String output buffer was potentially too small. Fixed to use the base64 string length which would be more than enough to fit decoded data.

@mtmk mtmk requested a review from caleblloyd February 9, 2024 20:00
@mtmk mtmk linked an issue Feb 9, 2024 that may be closed by this pull request
mtmk added a commit that referenced this pull request Feb 9, 2024
* All preview release features
* Should also include #387 when merged
@mtmk mtmk mentioned this pull request Feb 9, 2024
Copy link
Collaborator

@caleblloyd caleblloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mtmk mtmk merged commit 0f1523b into main Feb 10, 2024
9 of 10 checks passed
@mtmk mtmk deleted the 385-tryfrombase64string-buffer branch February 10, 2024 12:11
mtmk added a commit that referenced this pull request Feb 10, 2024
* All preview release features
* Should also include #387 when merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KV GetEntryAsync using TryFromBase64String buffer incorrectly
2 participants