Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of factories for better testability. #330

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Addition of factories for better testability. #330

merged 2 commits into from
Jan 16, 2024

Conversation

sspates
Copy link
Contributor

@sspates sspates commented Jan 13, 2024

Added factories to allow for better mocking, DI and testability.

mtmk
mtmk reviewed Jan 13, 2024
View reviewed changes
Copy link
Collaborator

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just needs a minor fix

src/NATS.Client.ObjectStore/INatsKVContextFactory.cs Outdated Show resolved Hide resolved
tests/NATS.Client.ObjectStore.Tests/NatsObjContextFactoryTest.cs Outdated Show resolved Hide resolved
@sspates sspates requested a review from mtmk January 16, 2024 21:25
mtmk
mtmk approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @sspates

@mtmk mtmk merged commit 9cb0cf9 into nats-io:main Jan 16, 2024
9 checks passed
mtmk added a commit that referenced this pull request Jan 17, 2024
@mtmk
Release 2.1.0-preview.3
f4dc38d 
* Ordered consumer optimizations (#336)
* Addition of factories for better testability. (#330)
* Nullability review for models (#332)
* Support Keyed DI services in .NET 8 (#331)
* (not merged yet) TLS auth timeout (#339)
@mtmk mtmk mentioned this pull request Jan 17, 2024
Merged
mtmk added a commit that referenced this pull request Jan 18, 2024
@mtmk
Release 2.1.0-preview.3 (#340)
199c242 
* Ordered consumer optimizations (#336)
* Addition of factories for better testability. (#330)
* Nullability review for models (#332)
* Support Keyed DI services in .NET 8 (#331)
* (not merged yet) TLS auth timeout (#339)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtmk mtmk mtmk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sspates @mtmk