Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log connection failure as warning #343

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Log connection failure as warning #343

merged 1 commit into from
Jan 19, 2024

Conversation

jasper-d
Copy link
Contributor

Fixes #342

mtmk
mtmk approved these changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @jasper-d

@mtmk
Copy link
Collaborator

mtmk commented Jan 19, 2024

Failed tests are flappers and tracked in #344

@mtmk mtmk merged commit e63496b into nats-io:main Jan 19, 2024
9 of 10 checks passed
mtmk added a commit that referenced this pull request Jan 23, 2024
@mtmk
Release 2.1.0-preview.4
82132c8 
* Async event handlers (#324)
* pipe reader: don't mark commands as consumed until pending=0 (#347)
* Log connection failure as warning (#343)
@mtmk mtmk mentioned this pull request Jan 23, 2024
Merged
mtmk added a commit that referenced this pull request Jan 23, 2024
@mtmk
Release 2.1.0-preview.4 (#350)
6b22255 
* Async event handlers (#324)
* pipe reader: don't mark commands as consumed until pending=0 (#347)
* Log connection failure as warning (#343)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtmk mtmk mtmk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Log connection failures as warnings
2 participants
@jasper-d @mtmk