pipe reader: don't mark commands as consumed until pending=0 #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Caleb Lloyd <caleb@synadia.com>
Closed
Merged
mtmk
added a commit
that referenced
this pull request
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes test from #346 (e90d588) - thanks for recreating @mtmk
Previously, commands that were partially trimmed but not sent had marked their data from the pipe reader as Consumed. On a Reconnect, the same amount of data would get Consumed again.
Refactors the Pipe Reader to only mark data as consumed once an entire command has been processed (pending == 0)
Also adds a bunch of comments to help explain the flow