Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NatsSvcServer start time format so that it's no longer culture aware #374

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Fix NatsSvcServer start time format so that it's no longer culture aware #374

merged 1 commit into from
Feb 4, 2024

Conversation

niklasfp
Copy link
Contributor

@niklasfp niklasfp commented Feb 4, 2024

Changes the started time format in NatsSvcServer to yyyy'-'MM'-'dd'T'HH':'mm':'ss'.'fffffff'Z' note the added ' (ticks) in the format, this makes sure its NOT affected by current culture, see DateTimeFormatInfo.UniversalSortableDateTimePattern Property on how the "iso" format is specified in .Net

Fixes #372

mtmk
mtmk approved these changes Feb 4, 2024
View reviewed changes
Copy link
Collaborator

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @niklasfp

@mtmk mtmk merged commit e16ac1a into nats-io:main Feb 4, 2024
10 checks passed
@niklasfp niklasfp deleted the 372-fix-service-time-format branch February 4, 2024 22:55
mtmk added a commit that referenced this pull request Feb 8, 2024
@mtmk
Release 2.1.0-preview.7
6f8ce6d 
* Send buffer fix (#380)
* Publish - avoid async state machine when possible (#373)
* Reject payloads over the threshold set by server (#378)
* Fix NatsSvcServer start time format so that it's no longer culture aware (#374)
* Expose Headers on NatsSvcMsg (#371)
@mtmk mtmk mentioned this pull request Feb 8, 2024
Merged
mtmk added a commit that referenced this pull request Feb 8, 2024
@mtmk
Release 2.1.0-preview.7 (#382)
5e66e0b 
* Send buffer fix (#380)
* Publish - avoid async state machine when possible (#373)
* Reject payloads over the threshold set by server (#378)
* Fix NatsSvcServer start time format so that it's no longer culture aware (#374)
* Expose Headers on NatsSvcMsg (#371)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtmk mtmk mtmk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Time format used for started time in services is culture dependent.
2 participants
@niklasfp @mtmk