Use ruff for linting

.github/workflows/check.yml

@@ -1,4 +1,4 @@
-name: Check
+name: check
 on:
     push:
         branches:
@@ -27,3 +27,24 @@ jobs:
 
             - name: Run format check
               run: uv run ruff format --check
+
+    lint:
+        runs-on: ubuntu-latest
+        name: lint
+        steps:
+            - name: Check out repository
+              uses: actions/checkout@v5
+
+            - name: Set up Python
+              uses: actions/setup-python@v6
+              with:
+                  python-version: "3.8"
+
+            - name: Install uv
+              uses: astral-sh/setup-uv@v6
+
+            - name: Install the project
+              run: uv sync --dev
+
+            - name: Run lint check
+              run: uv run ruff check

nats-server/src/nats/server/__init__.py

@@ -24,7 +24,6 @@
 import os
 import re
 import socket
-import tempfile
 from typing import Self
 
 # Set up logging

nats/examples/advanced.py

@@ -1,8 +1,9 @@
 import asyncio
 
-import nats
 from nats.errors import NoServersError, TimeoutError
 
+import nats
+
 
 async def main():
     async def disconnected_cb():

nats/examples/basic.py

@@ -1,9 +1,10 @@
 import asyncio
 
-import nats
 from common import args
 from nats.errors import TimeoutError
 
+import nats
+
 
 async def main():
     arguments, _ = args.get_args("Run a basic example.")
@@ -33,7 +34,7 @@ async def message_handler(msg):
         async for msg in sub.messages:
             print(f"Received a message on '{msg.subject} {msg.reply}': {msg.data.decode()}")
             await sub.unsubscribe()
-    except Exception as e:
+    except Exception:
         pass
 
     async def help_request(msg):

nats/examples/clustered.py

@@ -1,9 +1,10 @@
 import asyncio
 from datetime import datetime
 
-import nats
 from nats.aio.errors import ErrConnectionClosed, ErrNoServers, ErrTimeout
 
+import nats
+
 
 async def run():
     # Setup pool of servers from a NATS cluster.
@@ -66,7 +67,7 @@ async def subscribe_handler(msg):
             try:
                 await nc.publish(f"help.{i}", b"A")
                 await nc.flush(0.500)
-            except ErrConnectionClosed as e:
+            except ErrConnectionClosed:
                 print("Connection closed prematurely.")
                 break
             except ErrTimeout as e:

nats/examples/connect.py

@@ -1,8 +1,9 @@
 import asyncio
 
-import nats
 from common import args
 
+import nats
+
 
 async def main():
     async def disconnected_cb():

nats/examples/context-manager.py

@@ -1,8 +1,9 @@
 import asyncio
 
-import nats
 from common import args
 
+import nats
+
 
 async def main():
     is_done = asyncio.Future()

nats/examples/jetstream.py

@@ -1,8 +1,9 @@
 import asyncio
 
-import nats
 from nats.errors import TimeoutError
 
+import nats
+
 
 async def main():
     nc = await nats.connect("localhost")

nats/examples/micro/service.py

@@ -2,9 +2,10 @@
 import contextlib
 import signal
 
-import nats
 import nats.micro
 
+import nats
+
 
 async def echo(req) -> None:
     """Echo the request data back to the client."""

nats/examples/publish.py

@@ -1,8 +1,9 @@
 import asyncio
 
-import nats
 from common import args
 
+import nats
+
 
 async def main():
     arguments, _ = args.get_args("Run a publish example.", "Usage: python examples/publish.py")

nats/tests/test_client.py

@@ -8,10 +8,12 @@
 import urllib
 from unittest import mock
 
-import nats
 import nats.errors
 import pytest
-from nats.aio.client import Client as NATS, ServerVersion, __version__
+from nats.aio.client import Client as NATS
+from nats.aio.client import ServerVersion, __version__
+
+import nats
 from tests.utils import (
     ClusteringDiscoveryAuthTestCase,
     ClusteringTestCase,
@@ -669,9 +671,9 @@ async def next_msg():
 
         # FIXME: This message would be lost because cannot
         # reuse the future from the iterator that timed out.
-        await nc.publish(f"tests.2", b"bar")
+        await nc.publish("tests.2", b"bar")
 
-        await nc.publish(f"tests.3", b"bar")
+        await nc.publish("tests.3", b"bar")
         await nc.flush()
 
         # FIXME: this test is flaky
@@ -717,8 +719,8 @@ async def test_subscribe_next_msg(self):
             await sub.next_msg(timeout=0.5)
 
         # Send again a couple of messages.
-        await nc.publish(f"tests.2", b"bar")
-        await nc.publish(f"tests.3", b"bar")
+        await nc.publish("tests.2", b"bar")
+        await nc.publish("tests.3", b"bar")
         await nc.flush()
         msg = await sub.next_msg()
         self.assertEqual("tests.2", msg.subject)
@@ -2809,7 +2811,7 @@ async def test_drain_cancelled_errors_raised(self):
         async def cb(msg):
             await asyncio.sleep(20)
 
-        sub = await nc.subscribe(f"test.sub", cb=cb)
+        sub = await nc.subscribe("test.sub", cb=cb)
         await nc.publish("test.sub")
         await nc.publish("test.sub")
         await asyncio.sleep(0.1)

nats/tests/test_client_async_await.py

@@ -2,6 +2,7 @@
 
 from nats.aio.client import Client as NATS
 from nats.errors import SlowConsumerError, TimeoutError
+
 from tests.utils import SingleServerTestCase, async_test
 
 

nats/tests/test_client_nkeys.py

@@ -11,9 +11,11 @@
 except ModuleNotFoundError:
     nkeys_installed = False
 
-from nats.aio.client import Client as NATS, RawCredentials
+from nats.aio.client import Client as NATS
+from nats.aio.client import RawCredentials
 from nats.aio.errors import *
 from nats.errors import *
+
 from tests.utils import (
     NkeysServerTestCase,
     TrustedServerTestCase,

nats/tests/test_client_v2.py

@@ -1,7 +1,8 @@
 import unittest
 
-import nats
 from nats.aio.errors import *
+
+import nats
 from tests.utils import *
 
 

nats/tests/test_client_websocket.py

@@ -1,9 +1,10 @@
 import asyncio
 import unittest
 
-import nats
 import pytest
 from nats.aio.errors import *
+
+import nats
 from tests.utils import *
 
 try:

nats/tests/test_compatibility.py

@@ -7,7 +7,6 @@
 from typing import Any, Dict, List, Optional
 from unittest import TestCase, skipIf
 
-import nats
 from nats.aio.subscription import Subscription
 from nats.micro.request import ServiceError
 from nats.micro.service import (
@@ -18,6 +17,8 @@
     ServiceConfig,
 )
 
+import nats
+
 from .utils import *
 
 try: