Change NatsSubscription to a throwing AsyncSequence #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
|
This might be good for checking - both ways actually @piotrpio |
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
|
@Jarema thanks. I added handling queue in permissions denied error (if present) and fixed |
|
Great. Ready for review? :) |
Jarema
requested changes
Jun 6, 2024
| @@ -33,19 +57,77 @@ public enum NatsError { | |||
| } | |||
| init(_ error: String) { | |||
| let normalizedError = error.trimWhitespacesAndApostrophes().lowercased() | |||
There was a problem hiding this comment.
we can't normalize whole error, as it can contain case-sensitive subject that publish failed to.
Look here: nats-io/nats.rs#1258
There was a problem hiding this comment.
Right, for permission violation that's not a problem here as we only use the normalized version of the error to compare to "permissions violation". I changed the .proto case to include raw error string.
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Piotr Piotrowski piotr@synadia.com