Run latest pylint-nautobot #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmsirbu
reviewed
Feb 21, 2024
cmsirbu
reviewed
Feb 21, 2024
|
Any clue, where are Slack notifications sent? @cmsirbu 🙏 |
Right now, into the wrong channel I think :) That's used for pypi release notifications. |
whitej6
approved these changes
Mar 21, 2024
Kircheneer
reviewed
Mar 21, 2024
| run_command(context, " ".join(pylint_command)) | ||
| return | ||
|
|
||
| pip_and_pylint_command = ["pip install"] |
There was a problem hiding this comment.
Why do we have to pip install it here?
There was a problem hiding this comment.
For our implementation, similar to pylint-django, it's necessary to have the package installed.
There was a problem hiding this comment.
What I don't understand is why is this not installed by poetry?
There was a problem hiding this comment.
poetry install doesn't allow to specify the GitHub as a package source, works with local pyproject.toml only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Nan
What's Changed
invoke pylintto run with the latestpylint-nautobot.developwith the latestpylint-nautobot.