-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a pdb
flag under the unittest
task
#55
base: develop
Are you sure you want to change the base?
Conversation
@@ -827,6 +828,8 @@ def unittest( # noqa: PLR0913 | |||
command += " --failfast" | |||
if buffer: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps?
if buffer: | |
if buffer and not pdb: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I toyed with this idea but I feel it's a bit counterintuitive and against the "explicit better than implicit" principle. Just a personal opinion though, I'm OK to implement it this way if you feel strong about it...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whenever I put a breakpoint in a test and forget to use --no-buffer
it doesn't output anything and just freezes until I do a docker stop
on the container. Does the same thing happen with --pdb
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, you have to add --no-buffer
too to get to the interesting part. I take it you prefer to auto-add it as it makes more sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the behavior when you forget --no-buffer
is that it silently fails then I would prefer to add it automatically
Closes #194.