IS-2577: Add pdlClient to get name in api for journalforing #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eirikdahlen
commented
Aug 8, 2024
Comment on lines
+70
to
+73
| // Se behandlingskatalog https://behandlingskatalog.intern.nav.no/ | ||
| // Behandling: Sykefraværsoppfølging: Vurdere behov for oppfølging og rett til sykepenger etter §§ 8-4 og 8-8 | ||
| private const val BEHANDLINGSNUMMER_HEADER_KEY = "behandlingsnummer" | ||
| private const val BEHANDLINGSNUMMER_HEADER_VALUE = "B426" |
There was a problem hiding this comment.
Har dobbeltsjekket at dette er riktig behandling for denne casen også 👍🏼
| @@ -74,3 +74,7 @@ spec: | |||
| value: "dev-gcp.teamsykefravr.istilgangskontroll" | |||
| - name: ISTILGANGSKONTROLL_URL | |||
| value: "http://istilgangskontroll" | |||
| - name: PDL_CLIENT_ID | |||
There was a problem hiding this comment.
Må legge til en "rule" ovenfor under accessPolicy.
There was a problem hiding this comment.
Ja, den lå der visst fra en tidligere commit, helt sikkert noe vi kopierte over da vi lagde repoet bare 👍🏼
geir-waagboe
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Har bedt om tilgang til PDL her: https://jira.adeo.no/plugins/servlet/desk/portal/541/FAGSYSTEM-341015
EDIT: Fått tilgang ✅
For å journalføre må vi både legge inn PdlClient, DokarkivClient og CronjobModule. Starter med denne, så kommer det flere PRer etterhvert. For det meste copy+paste fra
isarbeidsuforhet.Ettersom brevmal ikke er klart enda, så tenker jeg å legge cronjobben bak en toggle, og så heller slå den på når vi har gjort klart PDF-generering med riktig mal. I mellomtiden kan vi lage malene i
ispdfgensånn at alt "henger sammen".Ble litt misvisende branch-navn...