Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IS-2697: Add forhandsvisning to ikke aktuell #1472

Merged
merged 2 commits into from
Sep 30, 2024
Merged

IS-2697: Add forhandsvisning to ikke aktuell #1472

merged 2 commits into from
Sep 30, 2024

Conversation

andersrognstad
Copy link
Contributor

No description provided.

@andersrognstad andersrognstad requested a review from a team as a code owner September 30, 2024 11:46
contentLabel={texts.buttons.previewContentLabel}
getDocumentComponents={() =>
getIkkeAktuellDocument({
begrunnelse: watch("begrunnelse"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blir det mer riktig med getValues? 😊 Vet ikke om vi risikerer å re-rendre ettersom watch(…) hele tiden vil oppdatere seg hver gang vi endrer begrunnelsen🤔 Uansett ønsker vi vel kanskje å bare hente ut verdien i øyeblikket vi trykker på knappen

Suggested change
begrunnelse: watch("begrunnelse"),
begrunnelse: getValues("begrunnelse"),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getDocumentComponents er en funksjon som kalles når vi trykker på knappen, så verdien hentes bare ut da. Men det blir kanskje mest riktig å bruke getValues uansett, endrer!

Copy link
Contributor

@vetlesolgaard vetlesolgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lite spørsmål, ellers gudd! 🙌

@andersrognstad andersrognstad merged commit 3240105 into master Sep 30, 2024
3 checks passed
@andersrognstad andersrognstad deleted the IS-2697 branch September 30, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants