Add float conversion warning to compile options #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The compilation in CI now fails with: which is good because it means that the check and CI works. The errors will be fixed by the float-conversion-related PRs which are now open. After these are merged, this can be merged. |
wenzeslaus
force-pushed
the
more-strict-compile
branch
from
3dfc183 to
d357bd2
Compare
|
The CI now passes. This will fail builds in CI and locally if there is a compiler (GCC or Clang) warning (from those enabled: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fail compilation when a compiler (GCC or Clang) warning is issued. The original motivation is catching -Wfloat-conversion in CI since we invested into fixing it.