-
Notifications
You must be signed in to change notification settings - Fork 1
Use new plugin priority from bioio to simplify code path #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR simplifies the codebase by delegating reader selection and fallback to bioio's internal priority system (bioio#162) rather than maintaining custom logic. The changes streamline the API by removing the determine_reader_plugin function and having nImage pass preferred readers as priority lists to bioio for automatic fallback handling.
Key Changes
- Removed
determine_reader_pluginfunction in favor of bioio's native priority system - Modified nImage to accept reader priority lists and handle fallback via bioio
- Changed
preferred_readerdefault frombioio-ome-tifftonullto enable automatic selection - Added
get_installed_plugins()utility for fast plugin detection via entry_points
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
src/ndevio/_plugin_manager.py |
Simplified to focus only on installation suggestions, removed reader selection logic |
src/ndevio/nimage.py |
Removed determine_reader_plugin, added _get_preferred_reader_list to pass priority to bioio |
src/ndevio/_napari_reader.py |
Simplified reader function to use nImage's automatic reader selection |
src/ndevio/_bioio_plugin_utils.py |
Added get_installed_plugins() function for fast plugin detection |
src/ndevio/widgets/_plugin_install_widget.py |
Updated to use BIOIO_PLUGINS directly instead of manager.known_plugins |
src/ndevio/ndev_settings.yaml |
Changed preferred_reader default to null for automatic selection |
.pre-commit-config.yaml |
Excluded ndev_settings.yaml from check-yaml hook |
tests/test_plugin_manager.py |
Updated tests to reflect simplified API |
tests/test_plugin_installer_widget.py |
Updated tests to work with new plugin detection |
tests/test_napari_reader.py |
Simplified tests to reflect new error handling flow |
tests/test_nimage.py |
Updated comment referencing renamed function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 18 out of 20 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
References and relevant issues
Depends on bioio-devs/bioio#162 / bioio v3.2.0
Description
reader=[Reader]to allow fallback to bioio's ordering (though this fallback is in nImage now)