Fix Pick() returning the same value multiple times #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #62
The cause behind this seems to have been the use of
Enumerable.Repeat
inDefaultPicker
, which calledPickPrioritized
once and repeated the result multiple times.A few questions from me before I consider this completely ready for review:
Pick
against other pickers; I believe if the bug was inDefaultPicker
the issue may have been more widespread than PrioritizedElements.Pick(n) returns the same value n times #62 describes (but haven't tested yet).ProbabilitiesMatter
assertion is a bit clunky, maybe it would be better to pass in the dict of random data?