Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: coin98 wallet add signMessage method #1122

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Conversation

khiemsoft
Copy link
Contributor

@khiemsoft khiemsoft commented Jun 26, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

@trechriron
Copy link
Collaborator

Please make a template selection above, fill in the details, and mark the appropriate checkboxes. Thanks!

@trechriron trechriron self-requested a review July 15, 2024 22:16
Copy link
Collaborator

@trechriron trechriron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please find and copy the correct template for your initial comment. You may have to resubmit. Please close this one if you do. You MUST have the checkboxes present or tests will not pass.
  2. Always make your initial PR against the DEV branch.

After these are fixed, we can review your changes. Thanks!

@trechriron
Copy link
Collaborator

@khiemsoft - did you see my request for changes?

@khiemsoft khiemsoft changed the base branch from main to dev July 24, 2024 08:18
@github-actions github-actions bot changed the title chore: coin98 wallet add signMessage method fix: coin98 wallet add signMessage method Jul 26, 2024
@khiemsoft
Copy link
Contributor Author

@khiemsoft - did you see my request for changes?

Hi, I just fixed this warning. Please verify it. Thanks for your support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: NEW❗
Development

Successfully merging this pull request may close these issues.

2 participants