Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix near-mobile-wallet, near-snap and ramper-wallet methods #1138

Conversation

gtsonevv
Copy link
Collaborator

@gtsonevv gtsonevv commented Jul 24, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

@gtsonevv gtsonevv requested a review from pivanov July 24, 2024 12:54

if (account == null) {
if (account == null || contracts.length < 1) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (account == null || contracts.length < 1) {
if (account === null || contracts.length < 1) {

@gtsonevv gtsonevv requested a review from amirsaran3 July 24, 2024 14:27
@gtsonevv gtsonevv requested a review from kujtimprenkuSQA July 25, 2024 10:01
@gtsonevv gtsonevv merged commit 565665d into SQC-540/add-signin-multi-breaking-change Jul 25, 2024
4 checks passed
@gtsonevv gtsonevv deleted the SQC-540/add-signin-multi-breaking-change-fix branch July 25, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants