chore(lint): migrate to flat ESLint config with neostandard #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
No linked issues found. Please add the corresponding issues in the pull request description. |
Puppo
commented
Dec 7, 2025
| @@ -1,14 +1,13 @@ | |||
| 'use strict' | |||
|
|
|||
| // eslint-disable-next-line n/no-unsupported-features/node-builtins | |||
Contributor
Author
ilteoood
reviewed
Dec 7, 2025
test/test.js
Outdated
| @@ -1007,15 +1005,18 @@ describe('General error handling', function () { | |||
| }) | |||
|
|
|||
| describe('Cleanup', function () { | |||
| test('should close the cache when the server stops', function (t, done) { | |||
| test('should close the cache when the server stops', async function (t, done) { | |||
Contributor
There was a problem hiding this comment.
I'm not so sure about mixing the async and done callback.
Maybe we should return a plain promise with reject/resolve?
Contributor
Author
There was a problem hiding this comment.
@ilteoood done.
Let's wait for the other PR before checking this one. The tests are broken.
Puppo
force-pushed
the
chore-upgrade-eslint
branch
from
75c4011 to
530c1bb
Compare
ilteoood
approved these changes
Dec 9, 2025
simoneb
approved these changes
Dec 9, 2025
This was referenced Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades ESLint from v8 to v9 and aligns the other dependencies based on this new version.
Wait #389 or #391 before merging