Adaptor for dynamodb streams #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A few information on some of the choices:
|
|
Hey @sakthivel-tw. Thank you so much for your contribution! I'm currently on leave for 2 weeks, I'll aim to have a look into this one at the end of next week. |
ceilfors
approved these changes
Nov 5, 2019
There was a problem hiding this comment.
Hi @sakthivel-tw. Thanks for your patience as I just got back from my holiday. This PR looks perfect to me and I'm happy to merge it (it's in Draft status at the moment).
The choice of using AWS.DynamoDB.Convert to unmarshall is great, I didn't know that such utility exist.
| @@ -7,5 +8,6 @@ const createEventAdapter = require("./createEventAdapter"); | |||
| exports.sns = createEventAdapter(new SnsJsonInputConverter()); | |||
| exports.sqs = createEventAdapter(new SqsJsonInputConverter()); | |||
| exports.kinesis = createEventAdapter(new KinesisJsonInputConverter()); | |||
| exports.dynamodb = createEventAdapter(new DynamoDbStreamJsonInputConvertor()); | |||
There was a problem hiding this comment.
Typo: Converter instead of Convertor
| @@ -0,0 +1,97 @@ | |||
| const merge = require("lodash/merge"); | |||
added 2 commits
November 5, 2019 12:45
|
@all-contributors please add @sakthivel-tw for code |
|
I've put up a pull request to add @sakthivel-tw! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adaptor support for dynamodb streams #152