Skip to content

Commit

Permalink
more clean up
Browse files Browse the repository at this point in the history
  • Loading branch information
Adam-D-Lewis committed Nov 4, 2024
1 parent 59daa0c commit e05f143
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ resource "azurerm_kubernetes_cluster" "main" {
min_count = var.node_groups[0].min_size
max_count = var.node_groups[0].max_size
max_pods = var.max_pods
# TODO: I don't think it's possible to add node_taints to the default node pool so we should throw an error somewhere if people try to do this
# see https://github.com/hashicorp/terraform-provider-azurerm/issues/9183 for more info
# TODO: It's not possible to add node_taints to the default node pool. See https://github.com/hashicorp/terraform-provider-azurerm/issues/9183 for more info

orchestrator_version = var.kubernetes_version
node_labels = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,6 @@ variable "environment" {
type = string
}


# variable "node_groups" {
# description = "Node pools to add to Azure Kubernetes Cluster"
# type = list(map(any))
# }

variable "node_groups" {
description = "Node pools to add to Azure Kubernetes Cluster"
type = list(object({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ variable "node_groups" {
min_size = 0
max_size = 2
labels = {}
node_taints = [] # TODO: Do this for other cloud providers
node_taints = []
},
{
name = "worker"
Expand Down

0 comments on commit e05f143

Please sign in to comment.