Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip running cleanup on pull requests #2488

Merged
merged 5 commits into from
Jun 18, 2024
Merged

Skip running cleanup on pull requests #2488

merged 5 commits into from
Jun 18, 2024

Conversation

aktech
Copy link
Member

@aktech aktech commented May 28, 2024

Reference Issues or PRs

Fixes #2252
Partially addresses #2413

Adding cleanup in the CI adds more problems than value, by skipping it in the pull requests, we will make out CI at least 2x faster, which means faster iteration cycle without loosing much as we're running it in the main anyways. This is a small trade-off and I feel its worth it.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@aktech aktech marked this pull request as ready for review May 31, 2024 11:56
@dcmcand dcmcand merged commit 8e189a8 into develop Jun 18, 2024
6 checks passed
@dcmcand dcmcand deleted the skip-cleanup-on-pr branch June 18, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

[BUG] - Cleanup step on takes way too long on CI (25 minutes!)
2 participants