Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused AWS terraform modules #2623

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Remove unused AWS terraform modules #2623

merged 1 commit into from
Aug 14, 2024

Conversation

marcelovilla
Copy link
Member

@marcelovilla marcelovilla commented Aug 13, 2024 •
edited by dcmcand
Loading

Reference Issues or PRs

Closes #2526
Closes #2624
Closes #2625
Closes #2626
Closes #2627
Closes #2628
Closes #2629
Closes #2630

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe): Remove unused legacy code

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

How to test this PR?

  1. Deploy Nebari to AWS
  2. Make sure all services work properly
  3. Destroy Nebari

@marcelovilla marcelovilla changed the title Remove unused modules Remove unused AWS terraform modules Aug 13, 2024
dcmcand
dcmcand approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@dcmcand dcmcand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a thing of beauty!

@marcelovilla marcelovilla merged commit 427b704 into develop Aug 14, 2024
31 of 32 checks passed
@marcelovilla marcelovilla deleted the remove-unused-aws-modules branch August 14, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcmcand dcmcand dcmcand approved these changes

@Adam-D-Lewis Adam-D-Lewis Awaiting requested review from Adam-D-Lewis

@viniciusdc viniciusdc Awaiting requested review from viniciusdc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@marcelovilla @dcmcand