-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
template the kustomization.yaml file #2667
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reminder to add documentation for this feature - we can add a "this is in beta testing" header |
aktech
requested changes
Sep 4, 2024
src/_nebari/stages/kubernetes_kuberhealthy/template/kustomization.yaml.tmpl
Outdated
Show resolved
Hide resolved
Thanks @aktech, I addressed all of your comments here. |
aktech
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, thanks! 🎉 This is good to merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
part of #2557
What does this implement/fix?
Adds the ability to template the
kustomization.yaml
file to allow variables from the config to be dynamically set.Put a
x
in the boxes that applyTesting
How to test this PR?
nebari render -c nebari-config.yaml
grep -r namespace stages/10-kubernetes-kuberhealthy/
andgrep -r namespace stages/11-kubernetes-kuberhealthy-healthchecks/
and verify that the correct namespace has been set (it should bedev
) by default.nebari-config.yaml
file and rerun the rendernebari deploy
to validate that everything deploys to the correct namespaceAny other comments?