Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template the kustomization.yaml file #2667

Merged
merged 6 commits into from
Sep 5, 2024
Merged

Conversation

dcmcand
Copy link
Contributor

@dcmcand dcmcand commented Aug 30, 2024

Reference Issues or PRs

part of #2557

What does this implement/fix?

Adds the ability to template the kustomization.yaml file to allow variables from the config to be dynamically set.

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

  1. enable healthchecks with
monitoring:
  healthchecks:
    enabled: true:
  1. run a render with nebari render -c nebari-config.yaml
  2. check the rendered objects namespace with grep -r namespace stages/10-kubernetes-kuberhealthy/ and grep -r namespace stages/11-kubernetes-kuberhealthy-healthchecks/ and verify that the correct namespace has been set (it should be dev) by default.
  3. change the namespace to a different namespace in your nebari-config.yaml file and rerun the render
  4. using the above commands, verify the namespace was updated.
  5. return to your original namespace and rerun the render
  6. run a nebari deploy to validate that everything deploys to the correct namespace

Any other comments?

@dcmcand dcmcand changed the title Add uptime monitoring template the kustomization.yaml file Aug 30, 2024
@dcmcand dcmcand marked this pull request as ready for review August 30, 2024 15:41
@kcpevey
Copy link
Contributor

kcpevey commented Sep 2, 2024

Reminder to add documentation for this feature - we can add a "this is in beta testing" header

src/_nebari/stages/base.py Show resolved Hide resolved
src/_nebari/stages/base.py Outdated Show resolved Hide resolved
@dcmcand dcmcand requested a review from aktech September 5, 2024 10:06
@dcmcand
Copy link
Contributor Author

dcmcand commented Sep 5, 2024

Thanks @aktech, I addressed all of your comments here.

Copy link
Member

@aktech aktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks! 🎉 This is good to merge!

@dcmcand dcmcand merged commit 6cc9317 into develop Sep 5, 2024
29 checks passed
@dcmcand dcmcand deleted the add-uptime-monitoring branch September 5, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

3 participants