Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precommit typos #2731

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Conversation

blakerosenthal
Copy link
Contributor

Reference Issues or PRs

Closes #2598

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

  1. Create a new local deployment from the develop branch in editable mode
  2. Run nebari render -c nebari-config.yaml
  3. Run ls stages/07-kubernetes-services/modules/kubernetes/services/dask-gateway/ and verify that the directory contains the misspelled controler.tf file.
  4. Checkout this branch and run nebari render -c nebari-config.yaml
  5. Re-run the ls from above and verify the file has been renamed to controller.tf

Any other comments?

@Adam-D-Lewis
Copy link
Member

@blakerosenthal Is this ready for review?

@blakerosenthal
Copy link
Contributor Author

@blakerosenthal Is this ready for review?

Yes, thank you!

Copy link
Member

@Adam-D-Lewis Adam-D-Lewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @blakerosenthal

@Adam-D-Lewis Adam-D-Lewis merged commit 00b9247 into nebari-dev:develop Oct 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

Enable file typo checking in typos
2 participants