refactor: avoid generating getters for "constants"#102
Open
Fiouz wants to merge 1 commit intonebula-plugins:mainfrom
Open
refactor: avoid generating getters for "constants"#102Fiouz wants to merge 1 commit intonebula-plugins:mainfrom
Fiouz wants to merge 1 commit intonebula-plugins:mainfrom
Conversation
It is unlikely that the original intent was to expose getters such as `getBUILT_BY_PROPERTY()`, so change those properties to public fields, for the benefit of a clearer API, and more idiomatic integration with statically compiled languages. https://docs.groovy-lang.org/docs/groovy-3.0.13/html/documentation/#_fields_and_properties That change is source-compatible with existing dynamically compiled Groovy, but breaks compatibility with any statically compiled language (including Groovy with @CompileStatic): as the getters are removed, they now need to refer to the newly exposed fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is unlikely that the original intent was to expose getters such as
getBUILT_BY_PROPERTY(), so change those properties topublicfields, for the benefit of a clearer API, and more idiomatic integration with statically compiled languages.https://docs.groovy-lang.org/docs/groovy-3.0.13/html/documentation/#_fields_and_properties
That change is source-compatible with existing dynamically compiled Groovy, but breaks compatibility with any statically compiled language (including Groovy with
@CompileStatic): as the getters are removed, they now need to refer to the newly exposed fields.