Skip to content

Comments

convert build to kts#119

Merged
wakingrufus merged 1 commit intomainfrom
modernize
Feb 20, 2026
Merged

convert build to kts#119
wakingrufus merged 1 commit intomainfrom
modernize

Conversation

@wakingrufus
Copy link
Member

convert some tests to kotlin and add more assertions

convert some tests to kotlin and add more assertions
@wakingrufus wakingrufus marked this pull request as ready for review February 20, 2026 20:47
provider | envVariables || expectedBuildInfo
'Titus' | [TITUS_JOB_ID: 'cf12af48-e347-11ea-87d0-0242ac130003', TITUS_TASK_ID: 'dbac27de-e347-11ea-87d0-0242ac130003', NETFLIX_INSTANCE_ID: 'my-netflix-instance-id', NETFLIX_APP: 'my-netflix-app', 'Build-Job': 'my-netflix-app'] || ['Build-Job': 'my-netflix-app', 'Build-Number': 'cf12af48-e347-11ea-87d0-0242ac130003', 'Build-Id': 'cf12af48-e347-11ea-87d0-0242ac130003', 'Build-Url': 'my-netflix-instance-id/cf12af48-e347-11ea-87d0-0242ac130003']
'Drone' | [DRONE: 'true', DRONE_REPO: 'org/my-repo', DRONE_BUILD_NUMBER: '1', 'Build-Job': 'org/my-repo'] || ['Build-Job': 'org/my-repo', 'Build-Number': '1', 'Build-Id': '1', 'Build-Url': "http://${AbstractContinuousIntegrationProvider.hostname()}/build/1"]
'Jenkins' | [JOB_NAME: 'org/my-repo', BUILD_ID: '1', 'BUILD_NUMBER': '10', 'Build-Job': 'org/my-repo', 'BUILD_URL': 'http://localhost/org/my-repo/10'] || ['Build-Job': 'org/my-repo', 'Build-Number': '10', 'Build-Id': '1', 'Build-Url': 'http://localhost/org/my-repo/10']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this intentional?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm..

@wakingrufus wakingrufus merged commit 8cf3874 into main Feb 20, 2026
3 checks passed
@wakingrufus wakingrufus deleted the modernize branch February 20, 2026 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants