Cache Invocable and prevent concurrent access into orc #71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever invoked, the
CallableFunction
wrapper locates the executable within the LLVM context.This makes calling a function not thread-safe as the underlying LLVM implementation is not thread-safe and introduces an unnecessary overhead.
For small functions, this lookup dominates the runtime. Note: This benchmark only measures the invocation. Compilation is done beforehand.
This PR caches the
Invocable
produced by the Compiler during construction of theCallableFunction
and thus skips the lookup within the invocation.Note: we can remove the release mode and benchmark commit and only pick the relevant commit