pop return value after lua_pcall

stack would have been growing for every coroutine yeild in Lua UI Commander script before this fix
neilstephens · Aug 21, 2024 · 6498c27 · 6498c27
1 parent 9767cd0
commit 6498c27
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/Code/Plugins/LuaUICommander/LuaInst.cpp b/Code/Plugins/LuaUICommander/LuaInst.cpp
@@ -161,11 +161,13 @@ void LuaInst::Runner(const std::string& args)
 		//should have a sleep time in ms on the stack (return value)
 		if(!lua_isinteger(L,-1))
 		{
+			lua_pop(L,retc);
 			completed = true;
 			lua_gc(L,LUA_GCCOLLECT);
 			return;
 		}
 		auto sleep_time_ms = lua_tointeger(L,-1);
+		lua_pop(L,retc);
 		if(sleep_time_ms < 0)
 		{
 			completed = true;