Skip to content

fix: wrap subpath in '' (#2754) #2755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2025
Merged

fix: wrap subpath in '' (#2754) #2755

merged 3 commits into from
May 23, 2025

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented May 13, 2025

before

[Check Spelling/Check Spelling] GoGitActionCache get content check-spelling/check-spelling with sha 001867346ea5ba54ea2660ec0d227ff5965813f8 subpath  at /Users/jsoref/.cache/act/check-spelling-check-spelling.git

after

[Check Spelling/Check Spelling] GoGitActionCache get content check-spelling/check-spelling with sha 001867346ea5ba54ea2660ec0d227ff5965813f8 subpath '' at /Users/jsoref/.cache/act/check-spelling-check-spelling.git

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@mergify mergify bot added the needs-work Extra attention is needed label May 13, 2025
Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ignoring that quoting it "correctly" could mean escaping ', I do not expect someone to parse this

Copy link

codecov bot commented May 13, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.65%. Comparing base (bd4bc99) to head (8874785).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
pkg/runner/action_cache.go 20.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2755   +/-   ##
=======================================
  Coverage   74.65%   74.65%           
=======================================
  Files          73       73           
  Lines       11139    11147    +8     
=======================================
+ Hits         8316     8322    +6     
- Misses       2186     2190    +4     
+ Partials      637      635    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jsoref
Copy link
Contributor Author

jsoref commented May 13, 2025

I mean, I'd rather act use `...` instead of '...', but that's a larger discussion and yes, some extra quoting adventures would be involved.

This PR is just for general English readability and consistency.

@ChristopherHX
Copy link
Contributor

ChristopherHX commented May 13, 2025

Your patch check has failed because the patch coverage (42.85%) is below the target coverage (50.00%)

I do not think we can run old and new actions cache tests in nektos/act (would double the test duration), so coverage is a problem....

my own version has removed the old actions cache, like I planned for nektos/act and has much better coverage for these Line of Code. We would need help from cplee to bypass this check.

@panekj
Copy link
Contributor

panekj commented May 23, 2025

I'd rather remove Codecov (or disable CI failure for it), I know it feels nice that numbers go up for good things but we are not a corporation that has to deliver certain quality, just few people trying to make things better. It would be better if it just reported coverage without killing contributions.

@mergify mergify bot removed the needs-work Extra attention is needed label May 23, 2025
@mergify mergify bot merged commit a8ac529 into nektos:master May 23, 2025
12 checks passed
@jsoref jsoref deleted the issue-2754 branch May 23, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

subpaths should be quoted to prevent nonsensical messages
3 participants