-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix: wrap subpath in '' (#2754) #2755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ignoring that quoting it "correctly" could mean escaping '
, I do not expect someone to parse this
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2755 +/- ##
=======================================
Coverage 74.65% 74.65%
=======================================
Files 73 73
Lines 11139 11147 +8
=======================================
+ Hits 8316 8322 +6
- Misses 2186 2190 +4
+ Partials 637 635 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I mean, I'd rather This PR is just for general English readability and consistency. |
I do not think we can run old and new actions cache tests in nektos/act (would double the test duration), so coverage is a problem.... my own version has removed the old actions cache, like I planned for nektos/act and has much better coverage for these Line of Code. We would need help from cplee to bypass this check. |
I'd rather remove Codecov (or disable CI failure for it), I know it feels nice that numbers go up for good things but we are not a corporation that has to deliver certain quality, just few people trying to make things better. It would be better if it just reported coverage without killing contributions. |
before
after