Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add $context to PropertyDescriberInterface::supports() #2393

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

DjordyKoert
Copy link
Collaborator

Description

#2388 (comment)

What type of PR is this? (check all applicable)

  • Bug Fix
  • Feature
  • Refactor
  • Deprecation
  • Breaking Change
  • Documentation Update
  • CI

Checklist

  • I have made corresponding changes to the documentation (docs/)
  • I have made corresponding changes to the changelog (CHANGELOG.md)

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.50%. Comparing base (c431718) to head (34d6b58).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...rc/PropertyDescriber/RequiredPropertyDescriber.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2393   +/-   ##
=======================================
  Coverage   89.50%   89.50%           
=======================================
  Files          78       78           
  Lines        2896     2896           
=======================================
  Hits         2592     2592           
  Misses        304      304           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DjordyKoert DjordyKoert merged commit 63345ae into master Nov 12, 2024
20 checks passed
@DjordyKoert DjordyKoert deleted the add-context-param branch November 12, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant