Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MapQuery): better overwrite for arrays #2436

Closed

Conversation

xavierleune
Copy link
Contributor

@xavierleune xavierleune commented Jan 21, 2025

Description

Hello everyone,

⚠️ This pull request should be merged after #2435 as I fixed tests in #2345, I started from here. In the meantime you can review the actual new commit.

The actual array detection on MapQueryParameter and MapQueryString makes parameters hard to combine with SF Attributes, this pull requests fixes it. I consider it as a bug fix, as the parameter overwriting is already implemented and working as intended for other types.

Thanks !

What type of PR is this? (check all applicable)

  • Bug Fix
  • Feature
  • Refactor
  • Deprecation
  • Breaking Change
  • Documentation Update
  • CI

Checklist

  • I have made corresponding changes to the documentation (docs/)
  • I have made corresponding changes to the changelog (CHANGELOG.md)

@xavierleune xavierleune changed the title fix(MapQuery) better overwrite for arrays fix(MapQuery): better overwrite for arrays Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.24%. Comparing base (8b4803f) to head (d84c88d).

Files with missing lines Patch % Lines
...entDescriber/SymfonyMapQueryParameterDescriber.php 96.42% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2436      +/-   ##
==========================================
+ Coverage   90.18%   90.24%   +0.06%     
==========================================
  Files          94       94              
  Lines        3067     3097      +30     
==========================================
+ Hits         2766     2795      +29     
- Misses        301      302       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xavierleune
Copy link
Contributor Author

I think I took the problem from the wrong perspective here, I probably should have changed the argument name in OA\Parameter, from myProperty to myProperty[] to have the thing, as sf can supports only this syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant