Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert spatialite to geopackage on any migration to 300 or above #171

Merged
merged 12 commits into from
Jan 24, 2025
Merged

Convert spatialite to geopackage on any migration to 300 or above #171

merged 12 commits into from
Jan 24, 2025

Conversation

margrietpalm
Copy link
Contributor

This implements the following logic on upgrade:

  1. check version
    • (unchanged) Raise MigrationMissingError if schematisation version is too old
    • (new) Raise UpgradeFailedError if schematisation is not a spatialite but has a version of 230 or older
    • (new) Raise UpgradeFailedError if schematisation is not a geopackage but has a version of 300 or newer
  2. (unchanged) set custom epsg code, this will result in a schematisation version 230
  3. (new) upgrade to revision if revision <= 230, otherwise upgrade to 230
  4. (new) upgrade spatialite version if requested
  5. (new) if revision > 230, convert to geopackage and finish upgrade

New and changed fuctionality (with added tests):

  • Added is_geopackage and is_spatialite properties to ModelSchema
  • Modified spatial_index module to work with geopackage

Note that the test schema for several tests have been changed from in_memory_sqlite to empty_sqlite_v4 because geopackage conversion only works with a file.

@margrietpalm
* Add last spatialite and first geopackage versions as constants
dbbce6e 
* Add is_spatialite and is_geopackage to ModelSchema and use them to prevent impossible upgrades

* Modify geopackage testing to use is_geopackage and is_spatialite

* Split up migration to run geopackage conversion after migration to last spatialite version
@margrietpalm
Create dummy migration to 300
bf46f40
@margrietpalm
Modify spatial index functionality to work with geopackage
fe17534
@margrietpalm
Several fixes related to validating schema versions and spatial indices
984ee14
@margrietpalm
Fix test for 230 migration
3ffdef7
@margrietpalm
Fix run_upgrade_test
2297947
@margrietpalm
Fix test_is_spatialite and test_is_geopackage
43a07cb
@margrietpalm
Fix test for spatialite 3 upgrade
dcaf6f5
@margrietpalm
Fix tests, that failed because geopackage conversion does not work wi…
97bc2f5 
…th in memory sqlite, by using empty_sqlite_v4 instead
@margrietpalm margrietpalm requested a review from elisalle January 17, 2025 14:06
@margrietpalm margrietpalm requested review from jpprins1 and elisalle and removed request for elisalle January 21, 2025 09:02
elisalle
elisalle approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@elisalle elisalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice work

@elisalle elisalle removed the request for review from jpprins1 January 21, 2025 15:03
@margrietpalm margrietpalm merged commit 9d54d98 into master Jan 24, 2025
5 checks passed
@margrietpalm margrietpalm deleted the margriet_138_force_geopackage branch January 24, 2025 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elisalle elisalle elisalle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@margrietpalm @elisalle