Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gridbuilder compatible to schema upgrades #356

Merged
merged 21 commits into from
May 22, 2024

Conversation

margrietpalm
Copy link
Contributor

@margrietpalm margrietpalm commented Mar 28, 2024

These changes are mainly tested in https://github.com/nens/schema_300_integration_tests. All integration tests pass, indicating that identical gridadmin files are reproduced.

@margrietpalm margrietpalm changed the title WIP: make gridbuilder compatible to schema upgrades Make gridbuilder compatible to schema upgrades Apr 8, 2024
Copy link
Collaborator

@caspervdw caspervdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments, good that changes are rather limited here.

threedigrid_builder/base/settings.py Show resolved Hide resolved
threedigrid_builder/base/settings.py Outdated Show resolved Hide resolved
threedigrid_builder/interface/db.py Outdated Show resolved Hide resolved
threedigrid_builder/interface/db.py Show resolved Hide resolved
@elisalle elisalle removed their request for review April 9, 2024 07:38
@margrietpalm margrietpalm merged commit 8c36410 into master May 22, 2024
8 checks passed
@margrietpalm margrietpalm deleted the margriet_355_schema_300_settings branch May 22, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants