P2P: fix UnknownCapability
validation and maintainig
#3647
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes peer discovery mechanism for the nodes with at least one
UnknownCapability
included into the list of node's capabilities.Follow the logic implemented in nspcc-dev/neo-go#3778: the node will relay
UnknownCapability
information through the network even if it's not known to the node itself. @roman-khimov, you may argue with the last commit, but I consider first and second commits as a must-have, otherwise discovery won't work for the nodes withUnknownCapability
(which is not the problem for NeoGo).Type of change
How Has This Been Tested?
Checklist: