Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4169: $path configuration parameter adds terminating slash #4191

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

vga91
Copy link
Collaborator

@vga91 vga91 commented Sep 18, 2024

Fixes #4169

The user probably had an unrelated problem with the issue,
as the 502 error should be a temporary bad gateway error.

In fact, the following command from curl, works both with and without the terminating slash.

curl  https://apoc-testing.openai.azure.com/openai/deployments/text-embedding-ada-002/embeddings/?api-version\=2023-07-01-preview\
  -H 'Content-Type: application/json' \
  -H 'api-key: <OPENAI_API_KEY>' \
  -d '{"input": ["Some Text"]}'

In any case, we made the change, as it is syntactically more correct, and to prevent potential errors that might occur in the future or with other non-OpenAI/Azure endpoints.

Anyway, we created a test case similar to the issue one.

@RobertoSannino RobertoSannino merged commit 0e6969a into dev Oct 7, 2024
5 checks passed
@RobertoSannino RobertoSannino deleted the issue-4169 branch October 7, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants