Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compile error with 5.24 and provisionally fixed docker and upload-artifact errors #4199

Merged
merged 6 commits into from
Oct 4, 2024

Conversation

vga91
Copy link
Collaborator

@vga91 vga91 commented Sep 30, 2024

Created another PR, waiting for: #4179,
which fails due to timeout exception.

  • Changed references and gitmodule to 5.24
  • Fixed compile error with 5.24 version due to Neo4j change, see here: neo4j/neo4j@2f2dc34
  • Removed code artifact implementation from ci.yaml, so that we download neo4j from mvn repository and dockerhub
  • updated upload-artifact version (which is not valid anymore)

try solving https://github.com/neo4j-contrib/neo4j-apoc-procedures/actions/runs/11167910649/job/31045136258?pr=4199#step:9:2191

@vga91 vga91 marked this pull request as draft October 3, 2024 12:19
@vga91 vga91 marked this pull request as ready for review October 4, 2024 09:34
@vga91 vga91 changed the title Fix compile error with 5.24 Fixed compile error with 5.24 and provisionally fixed docker and upload-artifact errors Oct 4, 2024
@RobertoSannino RobertoSannino merged commit 245dc0e into dev Oct 4, 2024
5 checks passed
@RobertoSannino RobertoSannino deleted the fix-compile-error-5.24 branch October 4, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants