resolve rollup highlight issue #343
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for neo4j-docs-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something in the way Antora 3.1.13 unzips a ui bundle file is failing with our bundle. Specifically, this change in load-ui.js.
We can still use our existing
gulp bundleto generate ui-bundle.zip and if you pass a local filesystem path to the Antora CLI you can use the generated zip just fine. But when theui-bundle-urlis an actual URL. It fails, and it fails silently in a way that doesn't log anything or get as far as generating the ./build directory.I traced it to our use of rollup.js and various rollup plugins. And something about the way we include highlight.js. There may be an option in
@rollup/plugin-commonjsthat resolves the issue, but this change seems to get us the highlight we need.