Add retrying to batch writing #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed number of retries (10) - Retries on three different flight errors Co-authored-by: Max Kießling <max.kiessling@neotechnology.com>
The ambition is to make sure to have received an ACK from the server before continuing to send a DONE message. Co-authored-by: Max Kießling <max.kiessling@neotechnology.com>
ali-ince
requested review from
ali-ince,
fbiville and
venikkin
as code owners
ali-ince
approved these changes
Oct 21, 2024
Mats-SX
commented
Oct 22, 2024
| @@ -10,6 +10,10 @@ | |||
|
|
|||
|
|
|||
| def gds_version(driver: neo4j.Driver) -> str: | |||
| with driver.session() as session: | |||
| data = session.run("CALL gds.debug.sysInfo()").to_df() | |||
| print(data) | |||
There was a problem hiding this comment.
@ali-ince Do you want to keep this print still?
There was a problem hiding this comment.
Yes please, because it took quite a bit of time to figure out that the GDS license on CI was expired :)
fbiville
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Max Kießling max.kiessling@neotechnology.com