Fix test mocks to use created_at instead of timestamp for Message objects#52
Open
Fix test mocks to use created_at instead of timestamp for Message objects#52
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: johnymontana <1222454+johnymontana@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on ADK and Vertex AI integrations
Fix test mocks to use created_at instead of timestamp for Message objects
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test mocks were setting
.timestampon Message objects, but the Message model (inheriting from MemoryEntry) uses.created_at. This mismatch caused tests to not properly validate production behavior.Changes
mock_message.timestamptomock_message.created_at(2 instances)mock_msg.timestamptomock_msg.created_at(4 instances)Production code in
handlers.pyandtypes.pywas already correct - both usemsg.created_at.isoformat()andmsg.created_atrespectively.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.