Skip to content

Comments

Expose model and task_type as public properties in VertexAIEmbedder#53

Open
Copilot wants to merge 2 commits intoadkfrom
copilot/sub-pr-35-again
Open

Expose model and task_type as public properties in VertexAIEmbedder#53
Copilot wants to merge 2 commits intoadkfrom
copilot/sub-pr-35-again

Conversation

Copy link

Copilot AI commented Feb 5, 2026

The VertexAIEmbedder class stored model and task_type as private attributes (_model, _task_type) but the example code attempted to access them as public properties, causing AttributeError.

Changes

  • Added model property to return the Vertex AI model name
  • Added task_type property to return the embedding task type
  • Updated class docstring to document the new public attributes
  • Added unit tests for both properties

Example

from neo4j_agent_memory.embeddings.vertex_ai import VertexAIEmbedder

embedder = VertexAIEmbedder(
    model="text-embedding-004",
    task_type="RETRIEVAL_DOCUMENT"
)

print(f"Model: {embedder.model}")           # Now works
print(f"Task Type: {embedder.task_type}")   # Now works

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@vercel
Copy link

vercel bot commented Feb 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agent-memory Ready Ready Preview, Comment Feb 5, 2026 2:39pm

Co-authored-by: johnymontana <1222454+johnymontana@users.noreply.github.com>
Copilot AI changed the title [WIP] Update adk and vertex ai integrations based on feedback Expose model and task_type as public properties in VertexAIEmbedder Feb 5, 2026
Copilot AI requested a review from johnymontana February 5, 2026 14:40
@johnymontana johnymontana marked this pull request as ready for review February 6, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants