Fix event loop blocking in Vertex AI embedder with asyncio.to_thread#59
Draft
Fix event loop blocking in Vertex AI embedder with asyncio.to_thread#59
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Implement asyncio.to_thread() in embed() and embed_batch() methods - Use TextEmbeddingInput to properly pass task_type parameter - Update unit tests to verify TextEmbeddingInput usage - Remove blocking synchronous API calls from async methods - Add proper type annotations to satisfy mypy Co-authored-by: johnymontana <1222454+johnymontana@users.noreply.github.com>
- Remove redundant type annotation on input_objs - Add type: ignore comment for mypy false positive on list variance Co-authored-by: johnymontana <1222454+johnymontana@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on ADK and Vertex AI integrations PR
Fix event loop blocking in Vertex AI embedder with asyncio.to_thread
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Vertex AI embedder's
embed()andembed_batch()methods were calling synchronous SDK methods directly from async functions, blocking the event loop during I/O operations.Changes
model.get_embeddings()calls withasyncio.to_thread()to offload synchronous API calls to thread poolTextEmbeddingInputobjects to passtask_typeparameter (the SDK requires wrapping strings with task metadata)TextEmbeddingInputobjects are constructed correctly with task_typeThe
task_typeparameter is not accepted byget_embeddings()directly - it must be passed viaTextEmbeddingInputwrapper objects per the Vertex AI SDK API design.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.