Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add row limit to query execution #258

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Add row limit to query execution #258

merged 3 commits into from
Aug 27, 2024

Conversation

OskarDamkjaer
Copy link
Collaborator

Adds a new cypher running function for user queries instead of the one created for Neo4j SDK functions. It's using the AsyncIterator api in the driver to stop consuming records after a set limit is hit. I also update the view to inform the user if the limit was hit.

I got an error message from Turborepo that told me to update the version 🤷

Copy link

changeset-bot bot commented Aug 20, 2024

⚠️ No Changeset found

Latest commit: 6806719

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ncordon ncordon self-requested a review August 21, 2024 16:20
@ncordon ncordon self-assigned this Aug 21, 2024
Copy link
Collaborator

@ncordon ncordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OskarDamkjaer OskarDamkjaer merged commit e2db916 into main Aug 27, 2024
4 checks passed
@OskarDamkjaer OskarDamkjaer deleted the lmit-rows branch August 27, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants