feat: expose parallelizable execution plan #285
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbiville
force-pushed
the
parallel_exec
branch
from
2454f50 to
b4aa71a
Compare
|
TODO: add some benchmark(able) sequential vs. parallel examples with Java driver |
venikkin
approved these changes
Sep 15, 2025
core/src/test/java/org/neo4j/importer/v1/pipeline/ImportExecutionPlanIT.java
Show resolved
Hide resolved
| assertThat(stages.get(0)) | ||
| .isEqualTo(new ImportStepStage(Set.of(categorySource, productInCategorySource, productSource))); | ||
| var productNodeStep = new NodeTargetStep( | ||
| new NodeTarget( |
There was a problem hiding this comment.
nit: I know we have constructors here primarily for deserialization. Do you think it is worth adding an optional builder support (though a constructor or as new NodeTarget.Builder().build() to make this more readable in other cases.
There was a problem hiding this comment.
💯 I have only taken care of deserialization as you guessed, so the available APIs are pretty verbose at the moment.
Builders would make a lot of sense indeed.
The `ImportPipeline` exposes a new API, that returns an `ImportExecutionPlan`. An execution plan is made of independent groups. Each group can be processed in parallel and is made of sequential stages. Each next stage, within the group, depends on the completion of the previous stage. Finally, each stage is made of independent steps, they can be processed in parallel.
fbiville
force-pushed
the
parallel_exec
branch
from
0a53701 to
062f07b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.