Conversation
AmirLayegh
force-pushed
the
amir/schema-extraction-properties
branch
from
edf8bbb to
00be32d
Compare
| 9.4 Properties that are supplementary information (phone numbers, descriptions, metadata) are typically optional. | ||
| 9.5 When uncertain, default to "required": false. | ||
| 9.6 If a property has a UNIQUENESS constraint, it MUST be marked as "required": true. | ||
| 7. Also model intermediate events or actions (e.g., transactions, encounters, orders, events, reports) as separate node types when they are mentioned. |
Contributor
There was a problem hiding this comment.
Nice! have you noticed improvement with this additional instruction wrt events being extracted?
Contributor
Author
There was a problem hiding this comment.
I’d say it helped in some cases, but we’re still missing several event-like entities (e.g., encounters, orders). It seems the instruction nudges the model, but coverage is still limited.
Contributor
There was a problem hiding this comment.
Why "as separate node types"?
Contributor
Author
There was a problem hiding this comment.
The intent is to emphasize that events should be node types, not relationships. However, made it more explicit and removed the "separate node type".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated the schema extraction prompt in
SchemaExtractionTemplateto improve property extraction for node types. The changes ensure that:additional_properties: truewhen properties cannot be identifiedThis addresses the issue where many node types were generated without properties, making schemas less useful for downstream processing.
Type of Change
Complexity
Complexity: Low
How Has This Been Tested?
Testing Details:
Checklist
The following requirements should have been met (depending on the changes in the branch):