Reload Interval Feature #52
Conversation
| @@ -3,6 +3,7 @@ | |||
| "version": "1.0.0-alpha.0", | |||
| "author": "Neo Financial Engineering <engineering@neofinancial.com>", | |||
| "license": "MIT", | |||
| "type": "module", | |||
There was a problem hiding this comment.
I could have sworn that I committed this change
| } | ||
| } | ||
|
|
||
| setTimeout( |
There was a problem hiding this comment.
This looks good but it seems like it should exist on the top level object, not in the loadPlugins function
There was a problem hiding this comment.
The reason I added here was because I didn't want to loop through the this.options.plugins array again in that top level function to get the shortest reload interval for plugins. Maybe I can return from the loadPlugins function the configs and also the shortest reload interval to be used on the main loadConfig function.
| @@ -4,5 +4,8 @@ | |||
| "swc": true, | |||
| "esm": true | |||
| }, | |||
| "compilerOptions": { | |||
There was a problem hiding this comment.
Are you sure this part is needed? I don't remember having to do this when I added type: module in the secrets manager plugin.
There was a problem hiding this comment.
Without that, I get this error
I think the reason is because the @tsconfig/node18 which we are extending from has this compilerOptions configuration
"compilerOptions": {
"lib": ["es2022"],
"module": "commonjs", <--- Maybe this config here is the culprit?
"target": "es2022",
"strict": true,
"esModuleInterop": true,
"skipLibCheck": true,
"forceConsistentCasingInFileNames": true,
"moduleResolution": "node"
}
There was a problem hiding this comment.
The /example/script-esm-ts is actually with the same problem. If I don't change the tsconfig file I get that same error.
The goal of these changes is to support reload intervals for config-dug. The main ideas are: