Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update capability documentation for planned refactor #13

Closed

Conversation

justliliandev
Copy link

@justliliandev justliliandev commented Sep 27, 2023

Updates the capability documentation to match the capability refactor neoforged/NeoForge#73
I try to keep parity to the PR if further changes happen.


Preview URL: https://pr-13.neoforged-docs-previews.pages.dev

@ChampionAsh5357 ChampionAsh5357 self-assigned this Sep 27, 2023
@ChampionAsh5357
Copy link
Contributor

I'm assigning myself so I can keep track of this. Request a review whenever you want me to take a look in its current state. This should probably be a draft until it gets merged.

@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) September 27, 2023 22:04 Active
@neoforged-pages-deployments
Copy link

Deploying with Cloudflare Pages

Name Result
Last commit: 1892a52ef0fe616441aeaef5e2b97f0286f9abcc
Status: ✅ Deploy successful!
Preview URL: https://995e9b8b.neoforged-docs-previews.pages.dev
PR Preview URL: https://pr-13.neoforged-docs-previews.pages.dev

@justliliandev justliliandev marked this pull request as draft September 27, 2023 22:19
@justliliandev
Copy link
Author

I'll probably reword and add a few things here and there (like the BlockCapabilityCache), but I would like to get an opinion: Where should the Capabilities Page go? It's currently under the data storage category, even though caps don't do that anymore. Should the page stay there to keep links working? Or which category should the page be put under?

@ChampionAsh5357
Copy link
Contributor

It's probably better to rename the entire section since caps, attachment data, and saved data are roughly the same category in my mind. Maybe something like 'extensions'?

@justliliandev
Copy link
Author

I've decided against the rename of the group to extensions, because that would exclude Codecs from the group and would clash with the Concepts of Extension Interfaces that are added by Neo

@justliliandev justliliandev marked this pull request as ready for review December 5, 2023 23:03
@ChampionAsh5357
Copy link
Contributor

Closing because of #34. Thank you for the work so far though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants